Use placeholder text for Provider Host input #8754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, this used a value in the input text field that had to be deleted by the user before the user could enter a real value.
github-actions
bot
added
team: webapp
jankeromnes
approved these changes
Mar 11, 2022
Codecov Report
@@ Coverage Diff @@
## main #8754 +/- ##
==========================================
- Coverage 12.31% 11.17% -1.14%
==========================================
Files 20 18 -2
Lines 1161 993 -168
==========================================
- Hits 143 111 -32
+ Misses 1014 880 -134
+ Partials 4 2 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Nice catch, @jankeromnes! We could restore the example URL when deleting the input or use Thanks for making this change @andrew-farries! |
roboquat
added
deployed: webapp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the default value in the Provider Host field on the new integration modal from a value that the user must delete before entering a valid host, to a placeholder that disappears when the input field has focus.
Before:
Screen.Recording.2022-03-10.at.14.48.44.mov
After:
Screen.Recording.2022-03-10.at.14.13.36.mov
Related Issue(s)
How to test
Open the modal at Settings -> Integrations -> Add integration and check that the value in the Provider Host field is now a placeholder not a value that must be deleted.
Release Notes
Documentation
No changes needed.